Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update mergify rules for kubernetes 1.27 #3744

Merged
merged 1 commit into from
Apr 27, 2023
Merged

ci: update mergify rules for kubernetes 1.27 #3744

merged 1 commit into from
Apr 27, 2023

Conversation

riya-singhal31
Copy link
Contributor

@riya-singhal31 riya-singhal31 commented Apr 12, 2023 •
edited
Loading

Updated mergify rules to consider tests on Kubernetes 1.27

@riya-singhal31 riya-singhal31 mentioned this pull request Apr 12, 2023
Closed
4 tasks
@mergify mergify bot added component/testing Additional test cases or CI work ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures Repo activity Process/activites on ceph-csi repo labels Apr 12, 2023
Madhu-1
Madhu-1 requested changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are required here first https://github.com/ceph/ceph-csi/blob/devel/.github/workflows/pull-request-commentor.yaml

Madhu-1
Madhu-1 reviewed Apr 12, 2023
View reviewed changes
.github/workflows/pull-request-commentor.yaml Outdated
with:
issue-number: ${{ github.event.pull_request.number }}
body: |
/test ci/centos/k8s-e2e-external-storage/1.27
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run all the tests on kubernetes 1.27 and see if deployment and E2E pass before mering the PR?

Ideally, we should have 2 PR's one for GitHub action change and another for mergify. If github action works fine, we can merge the mergigy PR as we won't be blocking other PRs from mergify if there is any issue with 1.27

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure. I'll run all the tests.

Okay, I'll add that to another PR then.
Thanks!

@riya-singhal31
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.27

@riya-singhal31
Copy link
Contributor Author

/test ci/centos/mini-e2e-helm/k8s-1.27

@riya-singhal31
Copy link
Contributor Author

/test ci/centos/k8s-e2e-external-storage/1.27

@riya-singhal31
Copy link
Contributor Author

@Madhu-1 could you please remove ci/skip/e2e label here. Seems like I don't have access to do so.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 12, 2023

@Madhu-1 could you please remove ci/skip/e2e label here. Seems like I don't have access to do so.

its added by the mergify bot, i think it will readd it again if i remove it can you please test this one on any other PR's?

@riya-singhal31
Copy link
Contributor Author

@Madhu-1 could you please remove ci/skip/e2e label here. Seems like I don't have access to do so.

its added by the mergify bot, i think it will readd it again if i remove it can you please test this one on any other PR's?

Yes, sure.
I've added a separate PR for github actions as well.

@riya-singhal31
Copy link
Contributor Author

1.27 is failing here, #3735.
So, we can go ahead with merging the github action PR only for now.
@Madhu-1

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 14, 2023

1.27 is failing here, #3735. So, we can go ahead with merging the github action PR only for now. @Madhu-1

No as the 1.27 CI is failing we cannot merge the PR.

Madhu-1
Madhu-1 requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible to merge this one until 1.2 CI passes

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 21, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2023

rebase

✅ Branch has been successfully rebased

@riya-singhal31
Copy link
Contributor Author

1.27 CI is passing now, so should we merge this now?
cc @Madhu-1 @nixpanic

@nixpanic nixpanic requested a review from Madhu-1 April 21, 2023 12:43
nixpanic
nixpanic approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Kubernetes 1.27 CI jobs are passing in #3608.

@riya-singhal31
Copy link
Contributor Author

Seems Kubernetes 1.27 CI jobs are passing in #3608.

Yes!

@humblec
Copy link
Collaborator

humblec commented Apr 27, 2023

considering 1.27 passes, @Madhu-1 can you remove the requested changes ?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 27, 2023

@Mergifyio rebase

@riya-singhal31 @Madhu-1
ci: update mergify rules for kubernetes 1.27
0927482 
Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2023

rebase

✅ Branch has been successfully rebased

@Madhu-1 Madhu-1 merged commit 014f814 into ceph:devel Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work Repo activity Process/activites on ceph-csi repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riya-singhal31 @Madhu-1 @humblec @nixpanic